Смеха ради: недостатки школокода

unit Codec;
{Процедуры шифрования и дешифрования символов.
Процедура ввода пароля. Автор: Галисеев Г.В. Киев}
interface
   procedure setPassword;
   function coder(bt: Byte): Byte;
   function decoder(bt: Byte): Byte;
implementation
var
  charCounter: Byte;
  sum: Integer;
  arr: string; { Пароль }
procedure setPassword;
const
  numberChar = 6;
begin
  repeat
  Write('Insert password: ' ) ;
  Readln(arr);
  if Length(arr)<=numberChar then
  Writeln(' ** Length must be more than 6 characters**');
until Length(arr)>numberChar;
charCounter := 1;
sum := 0;
end;

function randomGenerator: Integer;
var j, cyrcleCounter: Byte;
begin
  cyrcleCounter := charCounter;
  for j:=0 to Length(arr)-2 do begin
  Inc(sum,Integer(arr[cyrcleCounter]));
  if cyrcleCounter=Length(arr) then
    cyrcleCounter := 0 ;
    Inc (cyrcleCounter);
end;
  Inc(charCounter);
  if charCounter=Length(arr) then
    charCounter := 1;
    if sum > 255 then
    Result := sum mod 255
  else
    Result := sum;
end;

function coder;
var
temp: Integer;
begin
  temp := bt - randomGenerator;
  if temp<0 then
    Result := Byte(temp + 256)
  else
    Result := Byte(temp);
end;

function decoder;
var
temp: Integer;
begin
  temp := bt + randomGenerator;
  if temp>255 then
    Result := Byte(temp - 256)
  else Result := Byte(temp);
end;
end. 

.model tiny
.286
.code
	org 100h
start:
	call BeepTimer
	int 20h
;-------------
BeepTimer proc
; cx = 1/18.2 sec
; dx = Hz
	mov al,0b6h
	out 43h,al
	mov al,0
	out 42h,al
	mov al,(1193180/330)/256
	out 42h,al
	in al,61h
	or al,3
	out 61h,al
	mov cx,18
	call Delay
	in al,61h
	and al,0fch
	out 61h,al
	ret
endp
;-----------
Delay	proc
; cx = 1/18.2 sec
	push ax
	push bx
	push dx
	xor ah,ah
	int 1ah
	mov bx,dx
	add bx,cx
delay_loop:
	int 1ah
	cmp dx,bx
	jne delay_loop
	pop dx
	pop bx	
	pop ax
	ret
endp
end start

{$E+}
uses Crt,Graph;

const X10  = -10;
      Y10  = 0;
      M1   = 100;
      V1X0 = 0;
      V1Y0 = 0;

      X20  = 10;
      Y20  = 0;
      M2   = 1;
      V2X0 = 0;
      V2Y0 = 10;

      TAU  = 0.01;

      rCX = 320;
      rCY = 175;
      rMX = 10;
      rMY = 10;

      cColor1 = White;
      cColor2 = White;
      cTrace = DarkGray;


var Gd,Gm :Integer;
    X1,Y1,X2,Y2 :Double;
    V1X,V1Y,V2X,V2Y :Double;
    XC,YC :Double;
    X1i,Y1i,X2i,Y2i :Integer;
var DX,DY,R2,F :Double;
    A1X,A1Y,A2X,A2Y :Double;

begin
     DetectGraph (Gd,Gm);
     InitGraph (Gd,Gm,'C:\TP\BGI');

     X1 := X10;
     Y1 := Y10;
     X2 := X20;
     Y2 := Y20;
     V1X := V1X0;
     V1Y := V1Y0;
     V2X := V2X0;
     V2Y := V2Y0;
     while not KeyPressed do
     begin
{       XC := (X1+X2)/2+Sin(X1/100)*100;
       YC := (Y1+Y2)/2+Sin(Y1/100)*100;
       PutPixel (Round(rCX+rMX*(X1-XC)),Round(rCY-rMY*(Y1-YC)), White);
       PutPixel (Round(rCX+rMX*(X2-XC)),Round(rCY-rMY*(Y2-YC)), LightGray);}
       X1i := Round(rCX+rMX*X1);
       Y1i := Round(rCY-rMY*Y1);
       X2i := Round(rCX+rMX*X2);
       Y2i := Round(rCY-rMY*Y2);
       PutPixel (X1i,Y1i, cColor1);
       PutPixel (X2i,Y2i, cColor2);
       X1 := X1 + V1X*TAU;
       Y1 := Y1 + V1Y*TAU;
       X2 := X2 + V2X*TAU;
       Y2 := Y2 + V2Y*TAU;

       DX := X2-X1;
       DY := Y2-Y1;
       R2 := Sqr(DX)+Sqr(DY);
       F  := 1;
       A1X := F*DX/M1;
       A1Y := F*DY/M1;
       A2X := -(F*DX/M2);
       A2Y := -(F*DY/M2);

       V1X := V1X + A1X*TAU;
       V1Y := V1Y + A1Y*TAU;
       V2X := V2X + A2X*TAU;
       V2Y := V2Y + A2Y*TAU;
       PutPixel (X1i,Y1i, cTrace);
       PutPixel (X2i,Y2i, cTrace);
     end;
     ReadKey;
     CloseGraph;
end.

procedure TGeneratorForm1.CalcEpsilon (matrix1 :TDoubleMatrix);
var i1,j1 :Integer;
    e1p, e2p :Double;
    e1m, e2m :Double;
    dt :Double;
begin
     // Make ep,em
     // One ... for matrix,q
     with matrix1 do begin
       for i1 := 1 to n1 do begin
         A[(i1-1)*n2+3] := 0; // e+ [3]
         A[(i1-1)*n2+4] := 0; // e- [4]
       end;

       for i1 := 1 to n1 do begin
         e1p := 1E+60; e2p := 1E+60;
         e1m := 1E+60; e2m := 1E+60;
         for j1 := 1 to n1 do begin
           if (j1 < i1) then begin
             dt := (A[(i1-1)*n2+1]-A[(j1-1)*n2+1]);
             if (A[(i1-1)*n2+2] <= A[(j1-1)*n2+2]) and (dt < e1p) then e1p := dt;
             if (A[(i1-1)*n2+2] >= A[(j1-1)*n2+2]) and (dt < e1m) then e1m := dt;
           end;
           if (i1 < j1) then begin
             dt := (A[(j1-1)*n2+1]-A[(i1-1)*n2+1]);
             if (A[(i1-1)*n2+2] <= A[(j1-1)*n2+2]) and (dt < e2p) then e2p := dt;
             if (A[(i1-1)*n2+2] >= A[(j1-1)*n2+2]) and (dt < e2m) then e2m := dt;
           end;
         end;
         if (e2p > e1p) then A[(i1-1)*n2+3] := e2p //p
         else A[(i1-1)*n2+3] := e1p;
         if (e2m > e1m) then A[(i1-1)*n2+4] := e2m // m
         else A[(i1-1)*n2+4] := e1m;
       end;
     end;
end;
....

mov al,(1193180/330)/256

$ bc -q
(1193180/330)/256
14